Repository navigation
test: add unexpected disconnect guards to http2-body-delete.js - #5970
Open
Kesavamoorthig06 wants to merge 2 commits into
Open
Kesavamoorthig06 wants to merge 2 commits into
Kesavamoorthig06 wants to merge 2 commits into
Conversation
metcoder95
approved these changes
Oct 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5970 +/- ##
==========================================
- Coverage 86.92% 86.92% -0.01%
==========================================
Files 115 115
Lines 45749 45749
==========================================
- Hits 39767 39766 -1
- Misses 5982 5983 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
The only failing jobs are Node 22 runs on test/http2-request-never-settles.js, which is unrelated to this change (+5 lines in test/http2-body-delete.js only). It's the Node 22 abort from nodejs/node#64850 (reproduces on clean baseline without this patch). Node 24/25 jobs pass. |
Author
|
Synced with main, including #5961's Node 22 skip. Fresh workflows are waiting for approval. Could you approve the runs and merge if the checks pass? Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Refs: #251
Rationale
The two successful HTTP/2 DELETE tests do not check for unexpected disconnects. A silent reconnect could hide a connection error.
Changes
Use the existing
guardAgainstUnexpectedDisconnecthelper in both tests, astest/http2-connection.jsdoes. The helper ignores client shutdown and idle-socket timeouts.No production code changes.
Status
Validation on Node.js v22.23.3:
node --test test/http2-body-delete.js test/h2-disconnect-guard.js: 5 passed, 0 failed.npx --no-install eslint test/http2-body-delete.js: passed.git diff --check: passed.npm run test:h2:core: 120 passed, 1 failed. The failure is a Node.jsonread->IsFunction()assertion intest/http2-request-never-settles.js; it also reproduces on the clean baseline with this patch removed.