fix(module): resolve the ESLint class from the main entry in checker - #713
fix(module): resolve the ESLint class from the main entry in checker#713mansurkhoja wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe checker now uses the main Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized change restores checker linting with supported ESLint versions and presents no actionable merge-blocking risk beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
checker: truethrows on ESLint 10 and the dev server never starts linting:For flat config the checker defaults
eslintPathtoeslint/use-at-your-own-risk, but ESLint 10 removed the class exports from that entry:vite-plugin-eslint2looks forloadESLint/ESLint/FlatESLint/LegacyESLinton that module, finds none of them and ends up callingnew undefined().The main
eslintentry exportsESLintandloadESLint(), and has been flat-config aware since v9 — the lowest version in the peer range (^9.0.0 || ^10.0.0). So the dedicated entry is no longer needed for either config type, and the branch can go away entirely.Checked with eslint 10.8.1, nuxt 4.5.2, vite 8.2.1, vite-plugin-eslint2 5.3.0: the checker lints on start and on save again. Same result as the
eslintPath: 'eslint'workaround @sebbayer found in #657.Closes #657