contrib/aws: run cluster cleanup before reporting in post_build_actions - #12829
Open
nmazzilli3 wants to merge 1 commit into
Open
nmazzilli3 wants to merge 1 commit into
nmazzilli3 wants to merge 1 commit into
Conversation
nmazzilli3
force-pushed
the
fix-post-build-cleanup-order
branch
2 times, most recently
from
September 13, 2026 22:45
ee4f93f to
02bf3e2
Compare
When a build is aborted (e.g. by a force-push over a running build),
the junit step throws hudson.AbortException ('No test report files were
found') which prevents the cluster cleanup code from ever executing,
leaking manual clusters.
Fix by reordering post_build_actions() so that region cleanup runs
first, wrapped in try/catch per-region so a single region failure
cannot block the others. Reporting (junit, archiveArtifacts) moves
after cleanup and uses allowEmptyResults / allowEmptyArchive so it
cannot abort the post block. The cp of outputs also gets '|| true'
to tolerate a missing source directory.
Bug replicated in PR-12743 Run 18 by staging a run and then
force-pushing over it.
Signed-off-by: Nick Mazzilli <nmazzill@amazon.com>
nmazzilli3
force-pushed
the
fix-post-build-cleanup-order
branch
from
September 13, 2026 23:06
02bf3e2 to
e572aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a build is aborted (e.g. by a force-push over a running build), the junit step throws hudson.AbortException ('No test report files were found') which prevents the cluster cleanup code from ever executing, leaking manual clusters.
Fix by reordering post_build_actions() so that region cleanup runs first, wrapped in try/catch per-region so a single region failure cannot block the others. Reporting (junit, archiveArtifacts) moves after cleanup and uses allowEmptyResults / allowEmptyArchive so it cannot abort the post block. The cp of outputs also gets '|| true' to tolerate a missing source directory.
Bug replicated in PR-12743 Run 18 by staging a run and then force-pushing over it.