Skip to content

fix: improve landing page visual hierarchy and button contrast - #16809

Closed
amrendrasharma1328-a11y wants to merge 1 commit into
ohcnetwork:developfrom
amrendrasharma1328-a11y:fix/landing-page-ux-improvements
Closed

amrendrasharma1328-a11y wants to merge 1 commit into
ohcnetwork:developfrom
amrendrasharma1328-a11y:fix/landing-page-ux-improvements

Conversation

@amrendrasharma1328-a11y

@amrendrasharma1328-a11y amrendrasharma1328-a11y commented Sep 13, 2026

Copy link
Copy Markdown
  • Make patient login CTA visually primary with ring highlight
  • Darken primary_gradient button variant for better text contrast

Proposed Changes

Fixes #16808

Opened alongside the linked issue — happy to adjust scope or approach based on maintainer feedback.

  • Made the Patient login CTA visually primary on the landing page (variant="outline"variant="primary_gradient" + ring-2 ring-primary-500 on the card) to establish clear visual hierarchy between staff and patient login options, since patient logins are the more common entry point on this public-facing page.
  • Darkened the primary_gradient button variant (from-primary-700/800from-primary-800/900) to improve text contrast against the white label text.
  • Verified this variant isn't used elsewhere in a way that this change would visually break.

Tagging: @ohcnetwork/care-fe-code-reviewers

Merge Checklist

Screenshot 2026-09-14 031336 Screenshot 2026-09-14 031325
  • Add specs that demonstrate the bug or test the new feature.
  • Update product documentation.
  • Ensure that UI text is placed in I18n files.
  • Prepare a screenshot or demo video for the changelog entry and attach it to the issue.
  • Request peer reviews.
  • Complete QA on mobile devices.
  • Complete QA on desktop devices.
  • Add or update Playwright tests for related changes

Summary by CodeRabbit

  • Style
    • Darkened the primary gradient button colors for improved visual emphasis.
    • Highlighted the patient login card with a stronger border effect and shadow.
    • Updated the Patient Login button to use the primary gradient style.

- Make patient login CTA visually primary with ring highlight
- Darken primary_gradient button variant for better text contrast
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 01813642-d623-4b50-aadf-87b95126f7c5

📥 Commits

Reviewing files that changed from the base of the PR and between f7be181 and b88e3e1.

📒 Files selected for processing (2)
  • src/components/ui/button.tsx
  • src/pages/Landing/LandingPage.tsx

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

Changes

The PR darkens the shared primary_gradient button variant. It also gives the patient login card a primary ring, stronger shadow, and gradient button on the landing page.

Landing page visual hierarchy

Layer / File(s) Summary
Primary gradient contrast
src/components/ui/button.tsx
The primary_gradient variant uses primary-800 and primary-900 gradient stops, including a darker hover state.
Patient login emphasis
src/pages/Landing/LandingPage.tsx
The patient login card uses a primary ring and stronger shadow. Its button uses primary_gradient instead of the outline styling.

Suggested reviewers: amjithtitus09, jacobjeevan

Priority: ⬇️ Low

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to b88e3

The localized visual updates preserve the existing login behavior and use valid shared theme tokens.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the two main changes: improved landing page visual hierarchy and stronger button contrast.
Description check ✅ Passed The description includes the proposed changes, linked issue, implementation details, scope context, screenshots, reviewer tag, and merge checklist. Several optional verification items remain unchecked…
Linked Issues check ✅ Passed The changes satisfy issue #16808. LandingPage.tsx applies variant="primary_gradient" to the Patient login button and adds ring-2 ring-primary-500, with stronger shadow styling, to the Patient ca…
Out of Scope Changes check ✅ Passed The diff contains only the two changes requested by issue #16808: the Patient card and button styling in src/pages/Landing/LandingPage.tsx, and the shared primary_gradient styling in `src/componen…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@rithviknishad

Copy link
Copy Markdown
Member

@amrendrasharma1328-a11y avoid working on issues unless assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve landing page visual hierarchy and button contrast

2 participants