store username in the audit table #211

Activity

1. ghost assigned

   jojenki

   on Feb 22, 2012
2. jojenki

   closed this as completedin 28113a5on Feb 23, 2012
3. stevenolen commented on Mar 27, 2014

   

   stevenolen

   on Mar 27, 2014

   Member

   More actions

   we discovered yesterday that there are a number of calls that don't provide this info. A number of requests don't obtain their audit information from a parent -- they just create it on their own. One example would be the root request:

   https://github.com/ohmage/server/blob/master/src/org/ohmage/request/Request.java#L341
   this line should be modified to:
   Map<String, String[]> auditInfo = super.getAuditInformation();

   this happens for a number of requests, all of which should be changed.
4. stevenolen

   reopened this on Mar 27, 2014
5. jshslsky

   added a commit that references this issue on Mar 27, 2014

   Prevent overwrite of audit information from superclass. Closes #211

   This issue will close once commit e42a38a is merged into the 'master' branch.

   e42a38a
6. jshslsky

   closed this as completedon Mar 27, 2014
7. stevenolen commented on Mar 31, 2014

   

   stevenolen

   on Mar 31, 2014

   Member

   More actions

   @joshuaselsky it looks like mobility/read is still neglecting to store/return the username field. I don't see a similar auditInfo variable in the file to look at though. Does the change need to be made in the root request, maybe?
   https://github.com/ohmage/server/blob/master/src/org/ohmage/request/Request.java#L341
8. stevenolen

   reopened this on Mar 31, 2014
9. jojenki commented on Mar 31, 2014

   

   jojenki

   on Mar 31, 2014

   Contributor

   More actions

   mobility/read spawns two child requests, StreamReadRequests to be specific. Each of these will check the auth information, which is really the only difference between a Request and a UserRequest. Probably, when I designed this I changed MobilityReadRequest from a UserRequest into just a Request so that the auth information was only checked twice instead of three times.

   https://github.com/ohmage/server/blob/master/src/org/ohmage/request/mobility/MobilityReadRequest.java#L130-131

   To fix this, you can override getAuditInformation() in MobilityReadRequest that calls the two child requests, aggregates their entries, and returns that aggregation. (Don't forget to also call super.getAuditInformation() and aggregate that as well.) While there will be duplicate entries in the two requests' audit information maps, these can safely be overwritten. If you wanted to be extra safe, you can merge them in a way that would aggregate rather than overwrite, but then you will also want to make sure that you don't create duplicates.
10. stevenolen commented on Oct 23, 2015

    

    stevenolen

    on Oct 23, 2015

    Member

    More actions

    @hongsudt maybe you can do a quick sanity check while working on 2.17.1 to make sure all APIs are storing the user string in the audit log?
11. stevenolen

    unassigned

    jojenki

    on Oct 23, 2015
12. stevenolen

    modified the milestones: ohmage 2.10, 2.17.1This milestone has been deleted on Oct 23, 2015