INTEROP-9453: stackrox/opp-readiness: filter evicted pods from sensor readiness check

[amp-rh]

CheckSensorPods currently checks all sensor pods — including evicted/terminating ones — and requires all to have Ready=True. An evicted pod lingers with DisruptionTarget=True, Ready=False, causing false readiness failures even when the replacement pod is healthy.

 This adds --field-selector=status.phase=Running to the pod query so only active pods are checked. Evicted pods are scheduling artifacts, not readiness signals.

 Related: INTEROP-9453

[openshift-ci-robot]

@amp-rh: This pull request references INTEROP-9453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

CheckSensorPods currently checks all sensor pods — including evicted/terminating ones — and requires all to have Ready=True. An evicted pod lingers with DisruptionTarget=True, Ready=False, causing false readiness failures even when the replacement pod is healthy.

 This adds --field-selector=status.phase=Running to the pod query so only active pods are checked. Evicted pods are scheduling artifacts, not readiness signals.

 Related: INTEROP-9453

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

Warning

Review limit reached

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 132f8a03-cbf0-4117-8c25-580991d95ad4

📥 Commits

Reviewing files that changed from the base of the PR and between 2e95d87 and d451049.

📒 Files selected for processing (1)

• ci-operator/step-registry/stackrox/opp-readiness/stackrox-opp-readiness-commands.sh

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amp-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/stackrox/opp-readiness/OWNERS [amp-rh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@amp-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-stolostron-policy-collection-main-ocp4.22-interop-opp-aws	N/A	periodic	Registry content changed
periodic-ci-stolostron-policy-collection-main-ocp4.22-fips-interop-opp-aws	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.