Repository navigation
Conversation
Owner
|
@nuxnik Appreciate the PR! Give me a few days to dig deeper into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
./ghdb_scraper.py failed with JSONDecodeError: Expecting value: line 1 column 1 (char 0) despite the request returning HTTP 200.
Root cause
The request headers set Accept-Encoding: deflate, gzip, br. Exploit-DB honored br (brotli) and compressed the JSON response with it. Python has no built-in brotli support (the optional brotli package is not installed), so the response body was never decompressed, and response.json() received raw compressed bytes.
Change
ghdb_scraper.py:62 — Accept-Encoding changed from deflate, gzip, br to deflate, gzip. Both formats are decompressed natively by Python, so the server always returns a body the scraper can parse. No new dependencies required.
Verification