Skip to content

spdlog migration - #2223

Merged
Bambooin merged 2 commits into
osfans:developfrom
Bambooin:spdlog-migration
Nov 11, 2026
Merged

Bambooin merged 2 commits into
osfans:developfrom
Bambooin:spdlog-migration

Conversation

@Bambooin

Copy link
Copy Markdown
Collaborator

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #
Fixes #

Feature

Describe features of this pull request

Migrate spdlog with rime/librime#1254

  • build: migrate native logging from glog to spdlog
  • chore: upgrade librime with spdlog

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@Bambooin
Bambooin merged commit 76a9e76 into osfans:develop Nov 11, 2026
1 check passed
@Bambooin
Bambooin deleted the spdlog-migration branch November 11, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants