Repository navigation
Preserve parent unknown arguments across subcommands - #437
Merged
p-ranav merged 2 commits intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_known_args discards unknown arguments collected by a parent parser when it dispatches to a subcommand. With nested subcommands, only the deepest command's unknown arguments survive.
For example, tool --parent-extra P run --child-extra C leaf --leaf-extra L currently returns only --leaf-extra and L. This appends each child's unknown arguments to its parent's collected arguments, preserving all six tokens in order.
Adds coverage for parent-only and child-only unknowns, ordering and duplicates around known values, compound options, nested commands, argc/argv, propagated conversion errors, and unchanged strict-parser rejection.
Validation on upstream dc6bd1e with Windows UCRT GCC 13.2 and C++17:
This is independent of #436 and does not change argument validation or preprocessing. AI-assisted implementation and review; the patch was inspected and the reported tests were run locally.