Repository navigation
Fix store_into with configured scan parser - #439
Open
aaroncostapix wants to merge 1 commit into
Open
aaroncostapix wants to merge 1 commit into
aaroncostapix wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #415.
When
scan()is combined with scalar numericstore_into(), the destination was parsed again using the default decimal parser, causing valid non-decimal inputs to fail and potentially adding duplicate entries to the parsed-value history.This change uses the configured scan parser for destination storage at the registered action position. A dedicated
storage_actionpreserves action ordering and exception behavior without introducing duplicate stored values or triggering the resizing and truncation associated with ordinary void actions during repeated (.append()) argument parsing.Tests
x,X,o,b,u,i, anda) and invalid-input rejection..append()), and multi-token arguments (nargs).Validation
git diff --checkpassed.