Repository navigation
Stop a Svelte 5 vulnerability alert from automerging - #1069
Merged
Merged
Conversation
allowedVersions blocks Renovate’s normal update proposals from ever reaching v5, but a vulnerability alert bypasses allowedVersions the same way it already does for dompurify (see that rule’s own automerge: false, added for exactly this reason) – and unlike dompurify’s rule, this one had no override for it. #898 is already proof this isn’t hypothetical: a real security-labeled Svelte 5 PR, currently only blocked from merging because its CI happens to fail, not because anything actually prevents it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowedVersionsblocks Renovate’s normal update proposals from ever reaching v5, but a vulnerability alert bypassesallowedVersionsthe same way it already does for dompurify (see that rule’s ownautomerge: false, added for exactly this reason) – and unlike dompurify’s rule, this one had no override for it.generate: "dom"), and the 6th requires attribute-spread syntax on forms/inputs this codebase never uses. Not a live concern here – but the automerge gap was real regardless.🤖 Generated with Claude Code