Repository navigation
ci(v2): standard dependency audit - #390
Merged
Merged
Conversation
- Rename v2/audit-ignore to v2/npm-audit-ignore and convert its entry to the standard one-GHSA-id-per-line format (lockfile path moves into the comment). - Replace .github/scripts/v2/npm-audit.sh with the standard script, byte-identical to v2.5.x (blob c794a63): reads v2/npm-audit-ignore, fails closed on registry errors, warns on stale exceptions. - Remove the branch-local npm-audit job from the CI shim; main's reusable ci-v2.yml provides the Dependency Audit job and runs this script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
v2with the repo-wide dependency-audit standard.Merge order: merge this only after main's
ci(main): standard dependency auditPR. That PR adds theDependency Auditjob to the reusableci-v2.yml, which runs this branch's.github/scripts/v2/npm-audit.sh. This PR removes the branch-localnpm-auditjob from the shim, so until main's PR merges, no npm audit runs on this PR's CI. The audit was run locally instead (output below).Changes
v2/audit-ignore→v2/npm-audit-ignore. The entry is now a bare GHSA id (GHSA-83w8-p2f5-377r), the standard format. The lockfile path moved into the justification comment, and an advisory link was added. The justification is otherwise unchanged..github/scripts/v2/npm-audit.shis replaced with the standard script, byte-identical tov2.5.x(git blobc794a63b232267e4a331641c65696de96a9b71b9, sha25695dffb5a531cd500806868995306dbd7ee4cd353c26b3ec49d7c50f60bd8563a). It runsnpm audit --audit-level=highagainst every committedv2/**/package-lock.json, readsv2/npm-audit-ignore, fails closed when npm returns no usable report, and warns on stale exceptions (the old script failed on them)..github/workflows/ci.yml(shim): removed thenpm-auditjob and updated the header comment..github/scripts/v2/**stays in the pushpathsfilter, so edits to the script still trigger CI.Local audit (node 26.12.1, npm 12.2.0)
Also checked:
npm audit returned no usable report, exit 1).::warningand the script still exits 0.shellcheck,yamllintandprettier --checkpass.🤖 Generated with Claude Code