Repository navigation
test: cover Windows local access and stabilize clipboard progress checks - #852
Conversation
Add isolated named-pipe ACL and config-lock tests for the access-denied investigation in #357. Document the current open flags and the native evidence still needed to establish the cause on the reporting installation.
The regression test timed allocation, serialization, decoding, and payload validation against the partial-frame receive deadline. Under CPU contention this failed even after both frames were delivered successfully. Rely on the worker's unchanged deadline and the bounded receive wait. Retain complete payload verification, the backpressured-upload assertion, and cancellation checks.
|
Local CI verification: GitHub CI run https://github.com/penso/herdr-gpui/actions/runs/40589412773 is now green, including all four Windows check jobs (x64/ARM64, default/all features), both Windows native GUI jobs, and Linux/macOS checks. Both Windows failures are resolved. Remaining affected-installation QA is listed in the PR description. |
[Low impact] This PR appears safe to merge; no actionable issue was found. SummaryAdds isolated tests and investigation notes for Windows access failures. It does not change production access checks or claim to fix the reported denial.
Reviews (1) · Last reviewed commit: "test: measure clipboard progress through..." · Reviewed by Greptile |
Pass a borrowed Path to the named-pipe listener's ToWtf16 API and use the config test's anyhow context instead of unwrap_err. These Windows-only compilation and Clippy failures blocked both native CI architectures.
Summary
Related to #357. The reported access denial remains unresolved; these tests and investigation notes do not establish a fix.
QA
just formatandgit diff --cached --checkpassed.(umask 022; cargo test --locked -p herdr-gpui --bin herdr-gpui herdr_settings::tests)passed: 45 tests. The initialjust cirun failed 25 existing settings tests because the inheritedumask 002created group-writable fixtures.(umask 022; RUST_TEST_THREADS=2 cargo test --locked -p herdr-client --lib tests::clipboard_tests::session::uploads)passed: 8 tests after correcting the timing assertion. Earlier full runs exposed the assertion failure under CPU contention.(umask 022; RUST_TEST_THREADS=2 just ci)passed on final commit820fc4be35e4d5286c3625d0c2937442efc5c6e3after mergingorigin/main(Linux x86_64): formatting, file-size/sorting gates, workspace Clippy, default/all-feature tests, doctests, and Python checks.just check-commitsandgit diff origin/main...HEAD --checkpassed.just lint-linux: attempted, blocked because Docker is unavailable. The native Linux Clippy checks are included injust ci.PATH="/tmp/opencode/issue-357-mingw/root/usr/bin:$PATH" just lint-windowspassed with a user-local MinGW C/C++ toolchain: all targets with all features and without default features. Corrected the Windows-only listener path type and config-testunwrap_errlint found by CI.docs/windows-local-access.md.Native Windows and live GUI checks passed in GitHub CI; they were not run locally.