Repository navigation
Conversation
perlcriticrc enables policies from Perl::Critic::Bangs, Perl::Critic::Freenode and Perl::Critic::Moose, but none of them were declared, so a dev environment built from the develop prereqs could be missing them and perlcritic would refuse to run. Bangs is pinned to 1.10, the release that added ProhibitDebuggingModules. cpanfile regenerated via dzil build. Fixes #199 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 10 10
Lines 1134 1134
Branches 271 271
=======================================
Hits 1006 1006
Misses 73 73
Partials 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Declare Perl::Critic::Policy::Variables::ProhibitUnusedVarsStricter (0.116, the latest release) as a develop prereq so CI installs it, and enable it explicitly in perlcriticrc so a missing install fails loudly rather than the policy being silently skipped. pushd scope guards are exempted via allow_if_computed_by. Fix the existing violations by discarding unused $self and other unused list-assignment slots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
_is_word_interpreted_as_string, _classify, _sections and _reorder_section never used $self, and _unit only used it to call _classify. Make them plain functions, matching existing helpers such as _elem_loc and _extract_symbols_from_snippet, instead of discarding the invocant with undef. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199
Changes
[Prereqs / DevelopRequires]indist.ini. These provide theBangs::*,Freenode::*andMoose::*policies (and themoosetheme) thatperlcriticrcenables. Bangs is pinned to 1.10, the release that addedProhibitDebuggingModules.perlcriticrc, so a missing install fails loudly instead of being skipped, withallow_if_computed_by = pushdfor File::pushd scope guards.$self(_is_word_interpreted_as_stringinDocument.pm;_classify,_sections,_reorder_sectionand_unitinSorter.pm) are now called as plain functions, matching existing helpers such as_elem_loc. Unused list slots in three test files are replaced withundef.cpanfileregenerated withdzil build. The incidentalMETA.json/README.mdchurn from the build was not committed.Testing
Policy "Perl::Critic::Policy::Bangs::ProhibitDebuggingModules" is not installed.precious lint --allpasses on every file.dzil buildreproduces the committedcpanfile.prove -lr -j8 t: all 98 files / 333 tests pass.🤖 Generated with Claude Code · Opus 5.5