Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 88.71% 88.73% +0.01%
==========================================
Files 10 10
Lines 1134 1136 +2
Branches 271 272 +1
==========================================
+ Hits 1006 1008 +2
Misses 73 73
Partials 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
With MooseX::Types 0.50, type libraries such as MooseX::Types::Moose have a Moose metaclass. The uses_moose check then caused the whole include to be ignored, so missing type imports were never added. Don't ignore includes for MooseX::Types type libraries. Also make uses_moose load the module itself before looking for a metaclass, rather than relying on an earlier check having loaded it. Add a fixture type library which explicitly initializes a metaclass so that the behaviour is tested regardless of the installed MooseX::Types version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202
Cause
With MooseX::Types 0.50,
MooseX::TypesandMooseX::Types::Baseload Moose, so type libraries such asMooseX::Types::Mooseend up with a Moose metaclass.uses_moosewas then true,_build_is_ignoredskipped the whole include, and missing type imports (e.g.Strint/moosex-types-moose.t) were never added. 0.51 dropped the Moose dependency, which is why the test passed there.Changes
Include.pm: do not ignore includes for MooseX::Types type libraries (is_moose_type_class), even if they have a Moose metaclass.ExportInspector.pm:uses_moosenow loads the module itself before looking for a metaclass, rather than relying on an earlier check having loaded it.t/moose-type-library-with-meta.t, so the regression is covered regardless of the installed MooseX::Types version.Changesentry.Testing
PERL5LIB.prove -lr t, 99 files / 337 tests) passes against both MooseX::Types 0.50 and 0.51.🤖 Generated with Claude Code · Opus 5.5