Repository navigation
fix(mobile): DistanceTransformPlanner.next() calls undefined Error() - #587
Merged
Merged
Conversation
next() called Error("No distance map computed, you need to plan.")
instead of raising it -- Error isn't a builtin or ever imported, so
this crashed with NameError instead of the intended ValueError
whenever next() was called before plan(). Reported in PR #507
(2026-01-18), which also removed an unrelated from numpy import disp
that's since been independently fixed (NumPy 2.0 dropped numpy.disp).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 142 142
Lines 13788 13825 +37
=====================================
- Misses 13788 13825 +37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`next()` called `Error("No distance map computed, you need to plan.")`
instead of raising it -- `Error` isn't a builtin or ever imported, so this
crashed with `NameError` instead of the intended `ValueError` whenever
`next()` was called before `plan()`.
Reported in #507 (2026-01-18), which also removed an unrelated
`from numpy import disp` -- that half is already independently fixed
(NumPy 2.0 dropped `numpy.disp`, and the current file no longer imports it).
Fixes #507.
Test plan