Repository navigation
chore(ci): configure Codacy: no Bandit on tests, skip the Dynamixel and ROS sketches - #888
Merged
Merged
Conversation
A plain assert is how a test checks something. Bandit_B101 is meant for an assert that validates input in library code, since python -O removes it. Of the 1183 issues Codacy reported on main, 471 were B101, and 336 of those were in tests/. The check still applies to src/. CONTRIBUTING.md and AGENTS.md said that Codacy flags asserts in tests and to ignore it; they now say it is not run there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
enabled auto-merge (squash)
October 22, 2026 11:04
…odacy They are unmaintained sketches for hardware with no tests, and are already excluded from mypy. Of the 1183 issues Codacy reported on main, 182 were in them (165 Dynamixel, 17 ROS), 132 of those from the vendored Dynamixel SDK. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
petercorke
changed the title
Up to standards ✅🟢 Issues
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 146 146
Lines 17295 17295
=====================================
Misses 17295 17295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 22, 2026
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.codacy.ymlwith two exclusions.Codacy's Bandit check does not run on
tests/, as bdsim already does. A plainassertis the correct way to check something in a test; Bandit_B101 is meant for an assert that validates input in library code, whichpython -Oremoves. The check still applies tosrc/.backends/Dynamixelandbackends/ROSare not analysed at all. They are unmaintained sketches for hardware with no tests, and are already excluded from mypy.CONTRIBUTING.md and AGENTS.md said Codacy flags asserts in tests and to ignore it. They now say Bandit is not run there.
Why
Codacy reports 1183 issues on
main(grade B, 89). 471 are Bandit_B101, and 336 of those are intests/. 182 more are in the Dynamixel and ROS sketches (132 from the vendored Dynamixel SDK).Not changed
No code, tests or CI behavior. Codacy is advisory and is not a required check. The other things that may affect the grade (duplication, complexity, the vendored Eigen headers) are left for later, once this shows its effect on the next analysis.
Checked
The YAML parses. The effect on the Codacy score is not known until the next analysis of
main.🤖 Generated with Claude Code