Repository navigation
Make PC_MemSize regression checks independent of zlib implementation - #389
Open
devrimgunduz wants to merge 1 commit into
Open
devrimgunduz wants to merge 1 commit into
devrimgunduz wants to merge 1 commit into
Conversation
The dimensional patch tests summed PC_MemSize(), which includes the zlib-compressed size of each dimension. zlib-ng (the system zlib on Fedora 40+ and others) produces larger deflate output than classic zlib, so the sums (716 and 8773) differ and the pointcloud test fails. Check that PC_MemSize() is positive instead of asserting exact sizes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pointcloudregression test fails on distributions whose system zlib is zlib-ng (e.g. Fedora 44):The dimensional patch tests sum
PC_MemSize(), which includes the zlib-compressed size of every dimension. zlib-ng produces larger deflate output than classic zlib (e.g. 10 vs 8 bytes for the same 8-byte input at level 9), so the exact sums (716 and 8773) depend on the zlib implementation.This PR checks
Bool_And(PC_MemSize(pa) > 0)instead of asserting exact compressed sizes. Verified: all 3 tests pass on PG 14 with zlib-ng 2.3.3.🤖 Generated with Claude Code