Conversation
jrecosio
commented
Sep 18, 2026
jrecosio
commented
- Fix wrong app ID (public vs secure) for on-demand DataTables action links
- fix: secure ajax edit links app id
…inks
The secure list pages (Service Groups, Endpoints, Redirects, Business
Cards) build their per-row action links (edit/copy/delete) inside the
DataTables on-demand AJAX callback, using
LayoutExecutionContext.createForAjaxOrAction(aRequestScope).
That AJAX function is registered application-agnostically
(DataTablesOnDemandHelper.registerAjaxFunction(...) has no app ID) and
is therefore not covered by the usual /secure/* application-ID
determination filter. Without it, the application ID is resolved from
the session-wide 'last used application ID', which can be 'public' if
the public part of the SMP was used in the same browser session
before. In that case, the generated links are built against the
public menu tree instead of the secure one, and since the public tree
only has a single menu item ('start'), the edit link resolves to
'/public/.../menuitem-start?action=edit&...' instead of
'/secure/.../menuitem-service_groups?action=edit&...'.
Fix: explicitly pin the AJAX request to the secure application (the
same thing XServletFilterAppIDExplicit would do for a regular
/secure/* request) before resolving the LayoutExecutionContext. Added
as a shared helper createSecureWPECForAjax(...) in
AbstractSMPWebPageForm and used it in all four affected on-demand
callbacks.
Owner
|
I am having issues understanding the problem. I tried this locally and everything works as expected... Usually the App-ID should be stored in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.