Repository navigation
fix(tea): execWithTTYControl defer bug on Windows (v0.2.3) - #14
Merged
Merged
Conversation
- defer SetConsoleMode(originalMode) fired AFTER Resume(), undoing EnterRawMode and leaving terminal in cooked mode - Symptoms: arrow keys broken, OS echo enabled after ExecProcessWithTTY - Fix errorlint: use %w for both errors - Cascade rivo/uniseg removal from context-menu, hover-highlight examples - Update CHANGELOG v0.2.3, README version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execWithTTYControlbug on Windows:defer SetConsoleMode(originalMode)fired AFTERResume(), undoingEnterRawMode()and leaving terminal in cooked modeExecProcessWithTTY: arrow keys broken, OS echo enabled, line buffering activerivo/unisegremoval from remaining example go.mod filesChanges
tea/internal/application/program/tty_control_windows.go: remove harmful defer, fix errorlintexamples/context-menu/go.mod: remove unusedrivo/unisegindirectexamples/hover-highlight/go.mod: remove unusedrivo/unisegindirectCHANGELOG.md: add v0.2.3 sectionREADME.md: update version to v0.2.3Test plan
go test ./tea/...passes (all platforms)gofmt -l .cleangolangci-lintclean ontty_control_windows.goReported by: GoSh Shell Project