Add support for @ and magic constants in search - #1813
Open
lacatoire wants to merge 1 commit into
Open
Conversation
lacatoire
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
February 10, 2026 09:18
derickr
requested changes
Sep 1, 2026
derickr
left a comment
derickr
left a comment
Member
There was a problem hiding this comment.
There are conflicts in this PR now.
lacatoire
force-pushed
the
fix/search-special-chars-974
branch
2 times, most recently
from
September 1, 2026 13:20
f337edd to
fa6d2c3
Compare
The manual-lookup search did not consult is_known_term() or is_known_variable(), so searching for operators like @ or magic constants like __LINE__ returned no results. Now these are checked before falling back to the manual page lookup. Also adds all magic constants (__LINE__, __FILE__, __DIR__, etc.) to both $uri_aliases and is_known_term().
sy-records
force-pushed
the
fix/search-special-chars-974
branch
from
September 3, 2026 03:48
fa6d2c3 to
47d0578
Compare
Contributor
|
📊 Regression report for commit 47d0578 is at https://web-php-regression-report-pr-1813.preview.thephp.foundation |
Contributor
|
🚀 Preview for commit 47d0578 is available at https://web-php-pr-1813.preview.thephp.foundation |
sy-records
reviewed
Sep 3, 2026
| 'yield from' => 'language.generators.syntax.php#control-structures.yield.from', | ||
| 'yield' => 'language.generators.syntax.php#control-structures.yield', | ||
|
|
||
| '__line__' => 'language.constants.magic.php', |
Member
There was a problem hiding this comment.
Why do we need to add two entries? After the redirect via is_known_term, the request won't reach uri_aliases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manual-lookup.phpnow checksis_known_term()andis_known_variable()before falling back tofind_manual_page(), so searching for@now resolves to the error control operator page__LINE__,__FILE__,__DIR__,__FUNCTION__,__CLASS__,__TRAIT__,__METHOD__,__PROPERTY__,__NAMESPACE__) to both$uri_aliasesinerror.phpandis_known_term()inerrors.inc