Repository navigation
pkp/pkp-lib#13447 Allow automatic DOI assignment on item creation - #2495
Merged
Merged
Conversation
bozana
changed the title
3 tasks done
bozana
force-pushed
the
13447
branch
12 times, most recently
from
October 8, 2026 10:45
bac54d0 to
7b367d7
Compare
taslangraham
approved these changes
Oct 8, 2026
Tribunal33
pushed a commit
to Tribunal33/pkp-e2e
that referenced
this pull request
Oct 13, 2026
… effort small, defect; OMP main). On a press with "DOI Versioning" "Yes", "Mark DOIs Registered", "… Unregistered" and "… Needs Sync" answer with their success notice and change only the newest version's DOIs: OMP's getDoisForSubmission() reads the current publication alone, where OJS and OPS collect every version's. Walked on main on the default dataset (a book with three major versions; journal and preprint server as controls); 3.5 and older: none, no screen turns the setting on for a press. Upstream: pkp/pkp-lib#13447, whose open PRs pkp/omp#2495 and pkp/pkp-lib#13460 (read at their heads today) make the three actions reach every version, so the one-line fix (tried, with a neighbour check) is owed only if they are held back. A way round: mark a version before the next is published. A developer and a triage read, one revision. Register: OMP4 follows the report (user-visible → low), one Planned guard. U45's three owed reports are written. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Tribunal33
pushed a commit
to Tribunal33/pkp-e2e
that referenced
this pull request
Oct 13, 2026
…/ops#1435 with pkp-lib#13460; issues pkp/pkp-lib#13447, #13253), `ready` after round 9 of the PR review: reviewed at ojs `4af89a1412`, omp `b0ab0a5fb6`, ops `3e2105f42e`, pkp-lib `58c7f454ff`, nothing open. CI from the branch at those heads (37961761348): red only on U03 S4 (K-12780). The row lived on the branch alone until now. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Tribunal33
pushed a commit
to Tribunal33/pkp-e2e
that referenced
this pull request
Oct 13, 2026
…ffort small, was medium; regression against OPS 3.5). After pkp/pkp-lib#13460 and pkp/omp#2495 a press's DOI class reads every version's DOIs, so the fix is the one pkp-lib line for the three apps (fix-omp.diff deleted, its half is upstream), tried again on OJS, OMP and OPS: version 1.0 then reads "Needs Sync"; the fault itself is unchanged on main and OPS 3.5 does not show it. A new version now gets its DOI when it is created. After the developer and triage reads: the one consequence is said once (a preprint server's Crossref record for the earlier version lacks its link to the new one from the posting until the work's next deposit, which the new "Unregistered" DOI prompts anyway); on a DataCite journal the fix would leave 1.0 "Submitted" for good after "Deposit All", so it should land with or after pkp/pkp-lib#11591 (by the code); the branch does run on a press's and a preprint server's first publication, where it changes nothing; the guard is the e2e scenario. U45 A17's entry follows the Summary, its Report line deleted, and its guard is a Planned item. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Tribunal33
pushed a commit
to Tribunal33/pkp-e2e
that referenced
this pull request
Oct 13, 2026
…m, effort small; unchanged). Walked again on OMP main and 3.5 after pkp/omp#2495 rewrote the DOIs page's list query: with "Files" alone ticked the tab still reads "No items found." on main, and "Needs DOI" still leaves out a book missing only a file DOI on main and 3.5; the fix rebased onto the rewritten methods and tried again. After the developer and triage reads the report tells its two faults apart: the empty list is new on main and in no release (the regression, which carries the level), and the filters ignoring file DOIs are a defect since 3.4 that one fix covers too. New, walked: the status filter has a second caller, the bulk "Mark DOIs Needs Sync", refused with "DOI Updates Failed" for a book whose only registered DOI is a file's (main and 3.5; fixed with the fix in); with "Files" alone the two Status filters do not filter at all on 3.5. The backport note says which hunks place by hand. Kept walk: mode WALK=files. U45 OMP1's entry follows the Summary; its Report line deleted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see pkp/pkp-lib#13447
Also fixes #13253 (separate commit): getAllDepositableSubmissionIds() uses whereDepositablePublication() for publication, chapter, publication format and proof file DOIs, and finds the submission through each of them. Proof files are taken through their publication format, as elsewhere in this PR. The whereHasDoi() override counts chapter, format and proof file DOIs.