Convert axhline, axvline, and axline to layout shapes - #5719
Open
robertoffmoura wants to merge 1 commit into
Open
Convert axhline, axvline, and axline to layout shapes#5719robertoffmoura wants to merge 1 commit into
robertoffmoura wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpl_to_plotlysilently drops reference lines.axhline,axvline, andaxlineproduce lines with blended or axes transforms, which the renderer skipped with "I found a line that didn't have 'data' coordinates! I will not draw it, but I did not crash.". The converted figure ends up with the reference lines missing completely.Fix: reference lines are now drawn as layout line shapes:
ax.transData.inverted()go.layout.Shape(type="line")on the current subplotBefore: 0 shapes (lines dropped with a warning).
After: lines render as layout shapes spanning the axis limits.
Snippet to reproduce: