Handle multiple config files in watch mode - #536
Open
RyanZim wants to merge 1 commit into
Open
Conversation
Also optimized recompile list computation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Multi-config watch behavior still needs regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds support for watching multiple PostCSS configuration files and optimizes recompilation selection.
Changes:
- Tracks discovered configurations in a
Set. - Recompiles inputs when configurations change.
- Avoids unnecessary dependency-graph computation.
File summaries
| File | Summary | Review comment |
|---|---|---|
index.js |
Adds multi-config watching and optimized recompilation selection. | Nit (2 votes): Add integration coverage for separate inputs/configurations and verify each configuration change triggers recompilation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| }) | ||
|
|
||
| if (configFile) watcher.add(configFile) | ||
| if (configFiles.size) watcher.add([...configFiles]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also optimized recompile list computation