Skip to content

Magnite: Preserve device.ext.atts in outgoing bid requests #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 2 commits into from
Nov 2, 2026
Merged

Magnite: Preserve device.ext.atts in outgoing bid requests #4698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50da5a9
Magnite: Preserve device.ext.atts in outgoing bid requests
osulzhenko Nov 2, 2026
24f956b
update after review
osulzhenko Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/magnite/MagniteBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,7 @@ private Device makeDevice(Device device) {
? null
: device.toBuilder()
.ext(mapper.fillExtension(
ExtDevice.empty(),
ExtDevice.of(ObjectUtil.getIfNotNull(device.getExt(), ExtDevice::getAtts), null),
MagniteDeviceExt.of(MagniteDeviceExtRp.of(device.getPxratio()))))
.build();
}
Expand Down
26 changes: 26 additions & 0 deletions src/test/java/org/prebid/server/bidder/magnite/MagniteBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@
import org.prebid.server.proto.openrtb.ext.request.ExtApp;
import org.prebid.server.proto.openrtb.ext.request.ExtDeal;
import org.prebid.server.proto.openrtb.ext.request.ExtDealLine;
import org.prebid.server.proto.openrtb.ext.request.ExtDevice;
import org.prebid.server.proto.openrtb.ext.request.ExtDeviceInt;
import org.prebid.server.proto.openrtb.ext.request.ExtDevicePrebid;
import org.prebid.server.proto.openrtb.ext.request.ExtImpContext;
import org.prebid.server.proto.openrtb.ext.request.ExtImpPrebid;
import org.prebid.server.proto.openrtb.ext.request.ExtPublisher;
Expand Down Expand Up @@ -2269,6 +2272,29 @@ public void makeHttpRequestsShouldFillDeviceExtIfDevicePresent() throws JsonProc
.containsOnly(mapper.readTree("4.2"));
}

@Test
public void makeHttpRequestsShouldPreserveOnlyDeviceExtAtts() {
// given
final BidRequest bidRequest = givenBidRequest(
builder -> builder.device(Device.builder()
.ext(ExtDevice.of(1, ExtDevicePrebid.of(ExtDeviceInt.of(1, 1))))
.build()),
builder -> builder.video(Video.builder().build()),
identity());

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.extracting(HttpRequest::getPayload)
.extracting(BidRequest::getDevice)
.extracting(Device::getExt)
.extracting(ExtDevice::getAtts, ExtDevice::getPrebid)
.containsExactly(tuple(1, null));
}

@Test
public void makeHttpRequestsShouldFillSiteExtIfSitePresent() {
// given
Expand Down
Loading