Skip to content

Magnite: Preserve device.ext.atts in outgoing bid requests - #5068

Open
osulzhenko wants to merge 1 commit into
masterfrom
adapter/magnite
Open

osulzhenko wants to merge 1 commit into
masterfrom
adapter/magnite

Conversation

@osulzhenko

Copy link
Copy Markdown

No description provided.

@osulzhenko

Copy link
Copy Markdown
Author

JAVA PR: prebid/prebid-server-java#4698

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 201a2dc

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:176:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:192:	Builder					100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:204:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:229:	MakeRequests				79.7%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:545:	getMaxBids				88.9%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:564:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:583:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:602:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:639:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:647:	updateImpRpTarget			76.6%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:725:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:733:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:737:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:741:	addStringArrayAttribute			0.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:745:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:775:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:784:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:812:	isStringArray				100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:822:	isBoolArray				100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:832:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:843:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:851:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:860:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:880:	contains				75.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:889:	isVideo					100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:898:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:903:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:935:	setImpNative				82.4%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:964:	MakeBids				92.2%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:1064:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:1082:	resolveAdm				87.5%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:1097:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v4/adapters/rubicon/rubicon.go:1106:	updateBidExtWithMeta			83.3%
total:									(statements)				83.7%

@aleksUIX

aleksUIX commented Nov 5, 2026

Copy link
Copy Markdown

If device.ext.atts is null or outside 0–3, ParseDeviceExtATTS returns an error and the continue skips every imp, so Magnite gets no request. Before this change the request went out without atts, core's lmt.ModifyForIOS ignores the same error, and the merged Java change (prebid/prebid-server-java#4698) still sends the request. Can we drop an invalid atts and keep the request, with a test for "atts": null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants