Skip to content

fix(release-v3): open the release PR only after the release job - #97

Merged
louise-poole merged 1 commit into
mainfrom
ci/release-plz-pr-after-release
Nov 5, 2026
Merged

louise-poole merged 1 commit into
mainfrom
ci/release-plz-pr-after-release

Conversation

@louise-poole

Copy link
Copy Markdown
Contributor

Opens the release PR only after the release job finishes, so merging a release PR no longer opens a duplicate one.

Why

  • Duplicate release PRs: the release and release-PR jobs ran in parallel. The PR job checked out before the new tag existed, so it reopened a PR with the same commits and changelog. In fynd-labs this produced 0.2.8 and 0.2.11, both opened under 20 s after the previous tag.

Design decisions

  • A failed release blocks the PR job: if tagging fails, the last release can't be trusted, so skipping the PR update is safer than opening one from the wrong starting point.

🤖 Generated with Claude Code

WHY:
Merging a release PR started the release and release PR jobs together. The
PR job checked out before the new tag existed, still saw the previous tag as
the last release, and opened another release PR repeating the same changelog.

HOW:
- make the release PR job wait for the release job

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@louise-poole
louise-poole merged commit d8c9a5c into main Nov 5, 2026
3 checks passed
@louise-poole
louise-poole deleted the ci/release-plz-pr-after-release branch November 5, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants