Repository navigation
fix(tools): simulate swaps of tokens backed by the native balance - #726
Merged
Merged
Conversation
WHY: We would like the quote verifier to simulate USDC routes on Arc. Arc's node refuses state overrides of USDC's storage, so every such simulation fails today. HOW: - A caller marks a token whose balanceOf reads the native balance - Selling it: fund it with the native balance override, and approve the spender with a call before the swap in eth_simulateV1 - Buying it: zero the sender's native balance so the balance read measures only the swap output Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
louise-poole
approved these changes
Nov 9, 2026
louise-poole
left a comment
louise-poole
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! Good find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EthCallRunner.Blocked address). So no route that sells USDC on Arc can be simulated.Fix
approvebefore the swap, in the sameeth_simulateV1bundle.eth_simulateV1, selling the token fails with a clear error.Tested
Follow-up to ENG-6395.
🤖 Generated with Claude Code