Skip to content

Fix a missing initialization to satisfy a compiler warning - #23

Merged
AKuHAK merged 1 commit into
ps2homebrew:masterfrom
mrbass21:compilerWarningInitialization
Oct 9, 2026
Merged

AKuHAK merged 1 commit into
ps2homebrew:masterfrom
mrbass21:compilerWarningInitialization

Conversation

@mrbass21

@mrbass21 mrbass21 commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

Please note that checking that it worked was just compiling. This seems simple enough that there should be no adverse effects. It resolves a compiler warning.

@mrbass21
mrbass21 force-pushed the compilerWarningInitialization branch from 88241e0 to 716e2fb Compare August 15, 2026 19:19
@mrbass21
mrbass21 force-pushed the compilerWarningInitialization branch from 716e2fb to 81b0260 Compare August 15, 2026 19:25
@AKuHAK
AKuHAK requested a lite review from Copilot September 24, 2026 10:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The equivalent GUI target still needs the same sentinel initialization fix.

Review effort: Lite
Findings: None

What changed in this PR

Fixes compiler warnings by explicitly initializing function-pointer fields in diagnostic command sentinels.

Changes:

  • Updates sentinel initializers in base/mecha-main.c.
File Summary
base/​mecha-main.c Initializes both diagnostic command-table sentinel entries.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@AKuHAK
AKuHAK merged commit 61f15e2 into ps2homebrew:master Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants