Repository navigation
Add timestamps and overwrite protection to EEPROM dumps - #25
Open
2Crazy4Nick wants to merge 1 commit into
Open
2Crazy4Nick wants to merge 1 commit into
2Crazy4Nick wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The overwrite check can miss unreadable files, and EOF during confirmation causes an infinite loop.
2 open findings
What changed in this PR
Adds timestamped EEPROM dump filenames and overwrite confirmation.
Changes:
- Appends local timestamps to default dump filenames.
- Prompts before overwriting existing files.
- Reports cancelled dumps separately.
| File | Description |
|---|---|
base/eeprom-main.c |
Implements timestamped filenames and overwrite handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| u16 data; | ||
|
|
||
| /* Prevent accidental overwrites of existing dumps. */ | ||
| if ((dump = fopen(filename, "rb")) != NULL) |
Comment on lines
+23
to
+33
| char choice; | ||
|
|
||
| fclose(dump); | ||
|
|
||
| do | ||
| { | ||
| PlatShowMessage("File '%s' already exists. Overwrite? (Y/N): ", filename); | ||
| choice = getchar(); | ||
| while (getchar() != '\n') | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Dump cancelled.This prevents repeated EEPROM dumps from silently overwriting an existing backup.
Tested with the Unix build and verified both overwrite confirmation paths (
Y/N).No dependency changes are required.