Repository navigation
Recompute move_sum after a large value leaves - #629
Open
CAOShurong wants to merge 1 commit into
Open
CAOShurong wants to merge 1 commit into
CAOShurong wants to merge 1 commit into
Conversation
The running sum subtracts the outgoing value in the input dtype. After a value near 1e19 leaves, the remaining positive window can come back as 0. That window is added directly when the outgoing value dominates the result.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move_sum keeps a running total and subtracts the value that leaves the window. With a value near 1e19 in the window, that subtraction is coarser than the numbers that remain, so a later window of positive values came back as 0. When the outgoing value dominates the updated total, the current window is summed directly.
pytest --pyargs bottleneck on Windows with Python 3.13, run from doc so the installed package is imported: 209 passed, 1 xfailed. The xfailed test is test_memory_leak. Before this change the new regression reported 0.0 instead of 12.0. A local pytest plugin was disabled because it imports requests. Integer move_sum still uses the running float64 total. Sums that are themselves near the top of the float range are unchanged.
Fixes #480