fix: compare Attribute instances by identity in include/exclude - #1616
Open
TrueFurina wants to merge 2 commits into
Open
fix: compare Attribute instances by identity in include/exclude#1616TrueFurina wants to merge 2 commits into
Attribute instances by identity in include/exclude#1616TrueFurina wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #864:
exclude(fields(A).foo)/include(fields(A).foo)matchedAttributeinstances by equality, so two classes sharing a same-named attribute (e.g.repeated_field_name) would both be affected, even though only one was passed to the filter.Attributeinstances are independent from the classes they are defined on, and==compares their contents — so a same-named attribute on another class compared equal. The fix compares by identity (is), matching exactly the attribute instance the caller passed.Changes
src/attr/filters.py:attribute in attrs→any(attribute is a for a in attrs)in bothinclude_andexclude_tests/test_filters.py: addTestSameNameAcrossClasseswithC2/D2sharing arepeatedattribute, asserting exclusion/inclusion of one class's attribute does not affect the otherVerification
exclude(fields(C2).repeated)also rejectedfields(D2).repeated(cross-class false positive)exclude(fields(C2).repeated)rejectsC2.repeatedbut allowsD2.repeated;includebehaves symmetricallyast.parsepasses on both files; existingTestInclude/TestExcludeparametrized cases are unaffected (single-class scenarios compare identically)