Improve CSS of static release dashboard - #799
Merged
Merged
Conversation
Member
Member
Why don't we get the Bootstrap CSS when using the direct URL? |
Member
Author
|
Because it's all bundled into the Buildbot's stylesheet, which is only referenced from the React app shell. See: view-source:https://buildbot.python.org/#/release_status <link rel="stylesheet" crossorigin href="./assets/index-CQKNRskk.css">It's 212 KB and includes both Bootstrap and Buildbot CSS. The direct URL is just the rendered template without the full app. |
Member
|
Oh ok. Good to know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Visiting the direct URL:
Is much quicker than:
This is because the latter does nothing on screen for 1.5-4s as it downloads the app shell, a 1.1 MB React bundle, a 1.3 MB dashboard plugin, and then runs the app.
It can be nearly 14s for the whole page to be rendered (uncached) or 4s (cached).
The direct URL can be 5s (uncached) and 3s (cached).
But the CSS is a bit off for the direct URL, as we don't get the Bootstrap CSS of the full React route.
React route:
Direct URL:
This PR adds some CSS so the standalone dashboard looks better: