Skip to content

Improve CSS of static release dashboard - #799

Merged
StanFromIreland merged 2 commits into
python:mainfrom
hugovk:dashboard-css
Sep 23, 2026
Merged

StanFromIreland merged 2 commits into
python:mainfrom
hugovk:dashboard-css

Conversation

@hugovk

@hugovk hugovk commented Sep 22, 2026

Copy link
Copy Markdown
Member

Visiting the direct URL:

Is much quicker than:

This is because the latter does nothing on screen for 1.5-4s as it downloads the app shell, a 1.1 MB React bundle, a 1.3 MB dashboard plugin, and then runs the app.

It can be nearly 14s for the whole page to be rendered (uncached) or 4s (cached).

The direct URL can be 5s (uncached) and 3s (cached).


But the CSS is a bit off for the direct URL, as we don't get the Bootstrap CSS of the full React route.

React route:

image

Direct URL:

image

This PR adds some CSS so the standalone dashboard looks better:

image

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland
StanFromIreland merged commit 91501df into python:main Sep 23, 2026
1 check passed
@StanFromIreland

Copy link
Copy Markdown
Member

Looks good now!

image

@hugovk
hugovk deleted the dashboard-css branch September 23, 2026 09:16
@vstinner

Copy link
Copy Markdown
Member

But the CSS is a bit off for the direct URL, as we don't get the Bootstrap CSS of the full React route.

Why don't we get the Bootstrap CSS when using the direct URL?

@hugovk

hugovk commented Sep 23, 2026

Copy link
Copy Markdown
Member Author

Because it's all bundled into the Buildbot's stylesheet, which is only referenced from the React app shell. See:

view-source:https://buildbot.python.org/#/release_status

    <link rel="stylesheet" crossorigin href="./assets/index-CQKNRskk.css">

It's 212 KB and includes both Bootstrap and Buildbot CSS.

The direct URL is just the rendered template without the full app.

@vstinner

Copy link
Copy Markdown
Member

Oh ok. Good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants