gh-156831: Fix reference ownership in _testcapi.sequence_fast_get_item - #156832
Closed
BHUVANSH855 wants to merge 1 commit into
Closed
gh-156831: Fix reference ownership in _testcapi.sequence_fast_get_item#156832BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
BHUVANSH855
changed the title
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
This is an internal function, are our tests impacted by this? I agree with Bénédikt, I'm not sure why this needs to change.
StanFromIreland
added
the
pending
Member
|
It's not an issue in our tests because the items returned by |
ZeroIntensity
removed
the
pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-156831
_testcapi.sequence_fast_get_item()returns the value fromPySequence_Fast_GET_ITEM()directly.PySequence_Fast_GET_ITEM()returns a borrowed reference, so the wrapperneeds to create a new reference before returning the object.
Use
Py_NewRef()for the returned item and add a regression test that checksthe reference count is increased by one.
Tests:
./python -m test test_capi.test_abstract -v