The namespaces don't work as documented

[timuckun]

See the following gist https://gist.github.com/timuckun/4b1e8f860cd47e0dc27423cad9563f4d

Calling this file results in this output (notice the lack of namespaces)

 ./do
Commands:
  do dump            # dumps the database using pgdump
  do help [COMMAND]  # Describe available commands or one specific command
  do restore         # loads the database from pgdump

Commands:
  do help [COMMAND]  # Describe available commands or one specific command
  do start           # starts docker compose

[apurvis]

+1

[timuckun]

Is anybody even looking at these tickets?

[p8]

Renaming the file to Thorfile and removing the calls to start does show the namespace when running thor list

require 'thor'
require 'dotenv'
Dotenv.load

module Db
  class Ops < Thor
    namespace :db
    def self.exit_on_failure?
      true
    end

    desc 'dump', 'dumps the database using pgdump'
    def backup
      puts 'Backup'
    end
    desc 'restore', 'loads the database from pgdump'
    def restore
      puts 'restore'
    end
  end
end

module Docker
  class Commands < Thor
    namespace :docker
    desc 'start', 'starts docker compose'
    def start; end
  end
end

Outputs:

db
--
thor db:dump     # dumps the database using pgdump
thor db:restore  # loads the database from pgdump

docker
------
thor docker:start  # starts docker compose

I'm not sure what the expected behaviour is for the original example file.
Is this something Thor should support?

[p8]

Hmm, this also how the https://github.com/rails/thor/blob/5fb6206a6d2d7bfb40bcb851c2e118ba39f69757/spec/fixtures/help.thor is implemented so I guess this is a bug.

[JoelTowell]

I believe this is a duplicate of #249. I wrote up the underlying distinction in more detail here.

The gist is using Thor as a standalone executable by calling Db::Ops.start(ARGV) and Docker::Commands.start(ARGV). That runs two separate Thor classes directly, so it never goes through Thor::Runner's namespace lookup. For runner-style usage, these commands should live in a Thorfile and be invoked with thor, as noted above in this comment.

I also don't think spec/fixtures/help.thor demonstrates a bug here. That fixture is a single standalone Thor class with no explicit namespace, so it doesn't exercise namespaced command lookup.

I don't think this is a bug. It can probably be closed as a duplicate of #249, where the underlying behaviour is covered in more detail.