Skip to content

PHP 8.4 Implicitly marking parameter <x> as nullable is deprecated - #1077

Closed
3kbest wants to merge 1 commit into
ratchetphp:0.4.xfrom
3kbest:php84fix
Closed

3kbest wants to merge 1 commit into
ratchetphp:0.4.xfrom
3kbest:php84fix

Conversation

@3kbest

@3kbest 3kbest commented Nov 22, 2024

Copy link
Copy Markdown

Fixes Implicit Nullable Types for php8.4

@3kbest

3kbest commented Jan 17, 2025

Copy link
Copy Markdown
Author

@clue can this be merged?

@bytestream

Copy link
Copy Markdown

composer requires php 5.4, and these changes require php 7.1+

@3kbest

3kbest commented Feb 11, 2025

Copy link
Copy Markdown
Author

PHP 5.4 came out in 2012 and hit EOL in 2015, so it’s been outdated for almost a decade. Dropping it and requiring PHP 7.1+ makes way more sense in my opinion.

@PaulRotmann

PaulRotmann commented May 30, 2025 •

Copy link
Copy Markdown
Contributor

Hey! Thanks for this pull request 🙏

As part of our cleanup initiative (#1100), we're closing old PRs that have already been resolved. We've recently merged #1099 which implements the same idea, but turned out to be a bit more involved than initially anticipated.

If you have further improvements to suggest, feel free to open a new pull request. We appreciate your contributions and welcome any future enhancements. If you want to support Ratchet, please consider sponsoring our work! ❤️

Thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants