fix(go): pin data modules to reachable release tags - #753
Open
sharma0vineet wants to merge 1 commit into
Open
sharma0vineet wants to merge 1 commit into
sharma0vineet wants to merge 1 commit into
Conversation
The i18nify-go go.mod referenced two data modules by pseudo-version
whose underlying commits no longer exist in the repository:
business_entity v0.0.0-20260630122543-7e86a2db2139
country/subdivisions v0.0.0-20260818095336-eb167d02b811
Both SHAs came from PR branches that were squash-merged, so the
original commits were garbage collected and the refs became
unresolvable. This broke the release path of the "Auto-Generate Go
Packages" workflow, where `go mod tidy` resolves the full module graph:
business_entity@v0.0.0-20260630122543-7e86a2db2139:
invalid version: unknown revision 7e86a2d
Pin both modules to their published release tags (v1.0.0 and v1.0.8)
instead. Verified with `go mod tidy`, `go build ./...` and
`go test ./...` — all packages build and pass.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Auto-Generate Go Packages run failed on the
Update go.mod for all changed packagesstep:packages/i18nify-go/go.modreferenced two data modules by pseudo-version whose underlying commits no longer exist:i18nify-data/go/business_entityv0.0.0-20260630122543-7e86a2db2139i18nify-data/go/country/subdivisionsv0.0.0-20260818095336-eb167d02b811Both SHAs came from PR branches that were squash-merged, so the original commits were garbage collected and the refs became unresolvable.
The release path of the workflow runs
go mod tidy, which resolves the entire module graph — so the deadbusiness_entityref failed a run that was only meant to bumpcountry/subdivisions. The downstreamRelease i18nify-gojob never ran as a result.The
subdivisionsentry was masked in that run (the release step rewrites it to a tag beforetidy), but it is equally unreachable and would break any non-release CI path.Fix
Pin both modules to their published release tags:
business_entity→v1.0.0country/subdivisions→v1.0.8Verification
go mod tidy,go build ./...andgo test ./...all pass locally:Follow-up (not in this PR)
This is the same class of failure as #749.
.github/scripts/go/update-dependencies.shpins to branch HEAD SHAs, so every squash-merge can orphan the ref it just wrote. Worth hardening separately:i18nify-data/go/<pkg>/vX.Y.Zexists, instead of writing a pseudo-version.git cat-file -e <sha>over every pseudo-version ingo.mod, so this fails fast with a clear message rather than a crypticgo mod tidyerror weeks later.🤖 Generated with Claude Code