Repository navigation
Make Hermes source archive extraction repository-agnostic - #59589
Merged
Merged
Conversation
Summary: Download Hermes sources from the canonical `meta/hermes` repository and strip the archive’s top-level directory without matching its owner or repository name. This keeps `CMakeLists.txt` at the expected source root after repository moves; exclude empty directories so the archive wrapper is not recreated. Changelog: [Android][Fixed] - Fix Hermes source builds after the Hermes repository move Differential Revision: D128177063
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128177063. |
This was referenced Oct 28, 2026
robhogan
approved these changes
Oct 28, 2026
alanjhughes
pushed a commit
to expo/react-native
that referenced
this pull request
Oct 29, 2026
Summary: Download Hermes sources from the canonical `meta/hermes` repository and strip the archive’s top-level directory without matching its owner or repository name. This keeps `CMakeLists.txt` at the expected source root after repository moves; exclude empty directories so the archive wrapper is not recreated. Changelog: [Android][Fixed] - Fix Hermes source builds after the Hermes repository move Differential Revision: D128177063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Download Hermes sources from the canonical
meta/hermesrepository and strip the archive’s top-level directory without matching its owner or repository name. This keepsCMakeLists.txtat the expected source root after repository moves; exclude empty directories so the archive wrapper is not recreated.Changelog:
[Android][Fixed] - Fix Hermes source builds after the Hermes repository move
Differential Revision: D128177063