Repository navigation
Stop setting the removed bridge key in RCTBlobManagerTests - #59605
Merged
javache merged 1 commit intoOct 29, 2026
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
javache
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#59250 removed
@synthesize bridge = _bridge;fromRCTBlobManager.mm, so the module no longer has abridgesetter or ivar.RCTBlobManagerTestsstill called[_module setValue:nil forKey:@"bridge"]insetUp, which now throwsNSUnknownKeyExceptionand fails all five tests before they run. The module never readsbridge, so the line can just go.Fixes #59597
Changelog:
[INTERNAL] [FIXED] - Fix RCTBlobManagerTests setUp after the bridge property was removed
Test Plan:
I don't have Xcode on this machine, so I couldn't run the RNTester XCTests. I checked the behavior with a small Foundation program: a class that adopts a protocol with a readonly
bridgeproperty but doesn't synthesize it throwsNSUnknownKeyExceptiononsetValue:nil forKey:@"bridge", and the same class with@synthesizedoesn't. The rest ofsetUp(initialize,store:withId:) doesn't depend onbridge.