Skip to content

Claude code review updates for set_tf_vars #496

Description

@dvalinrh

1 (cross-role template dependency) — added a header comment documenting that this role has no templates of its own and requires the caller to supply tfvars.j2/tfvars_disks.j2 via the ../templates/ search-path mechanism. Also rewrote README.md, which was copy-pasted from an unrelated teardown role (it described terminating instances/volumes) — it now accurately describes what this role does, its inputs, and its callers.

  • 2 (opaque disk parsing) — added a comment explaining that cloud_disks is a burden-formatted list rendered via Python repr, and that the cut -d"'" / sed s/'//g steps exist solely to strip those repr single-quotes.
  • 3 (read-only shells) — marked the five parse tasks changed_when: false so they stop reporting "changed" every run, with a note. As flagged, I did not add hard fail-on-empty validation because the [] and ["0:na:na:0"] sentinels burden emits are legitimate and would trip it — tell me if you want strict validation and I'll scope it to only the truly-malformed case.
  • 4 (misplaced comment) — moved/generalized the "Parse the disk line" comment down to the disk block where the parsing actually happens.
  • 4 (append idempotency) — added a comment warning that the cat >> tfvars.j2 append is only safe because the preceding copy overwrites fresh, so nobody converts it to create-if-missing.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

pr_approved[Automatic Label] Issue has an approved PR

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions