Repository navigation
Conversation
For bulk chunk data packet
booky10
approved these changes
Oct 15, 2026
booky10
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, and also added some minor changes/improvements
0002f2c#diff-f324d7963c6177fb5a6763389a67c36b842d3a40a09530c32a5f916dab21c1a7R155
Don't know much about 1.8 chunk format, but this seemed like a bug to me - can you confirm this?
Contributor
Author
|
The previous Also, the light loops in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of 1.8 chunk handling, reduces allocations by quite a bit. Deprecates
NetworkChunkData chunksToData(Chunk_v1_8[] chunks, byte[] biomes)as it's entirely skipped now to reduce memory copies.