Repository navigation
Fix reading WrapperPlayServerUpdateScore erasing target objective in 1.8 until 1.20.2 - #1610
Merged
Merged
Conversation
booky10
approved these changes
Oct 24, 2026
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PacketEvents would read the
objectiveNamevariable, then if the action isREMOVE_ITEMit would setobjectiveNameto""And by doing so, that means if you are trying to reset a score for a specific objective, and PacketEvents intercepted this packet, it would turn the packet into resetting for EVERY objective 😭 😭 😭 😭 😭
This PR fixes it so it is preserved and only resets what it is supposed to reset