Repository navigation
Conversation
hxyulin
force-pushed
the
fix/dynamic-sequence-proxy-size
branch
from
October 23, 2026 05:44
797d1d0 to
dc45bed
Compare
Remove checks against Rust proxy size and alignment when building proxies for C sequence elements. Add one regression using builtin_interfaces/Time to cover immutable and mutable singleton access without additional dependencies. The native regression reproduces the upstream assertion and passes with the fix in debug and release on macOS arm64 with ROS 2 Jazzy. Fixes ros2-rust#664. Assisted-by: Codex:gpt-6.1-sol
hxyulin
force-pushed
the
fix/dynamic-sequence-proxy-size
branch
from
October 23, 2026 05:47
dc45bed to
3f20fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664.
proxy_elemsandproxy_elems_mutcheck C sequence storage against the size/alignment of a Rust proxy struct. Those layouts are unrelated, so valid small message sequences panic. Remove these two checks; element-sized slicing and proxy construction remain unchanged.One regression uses the existing
builtin_interfaces/Timetype (8 bytes) to read and mutate a singleton through both proxy paths. It fails on the upstream implementation and passes with the fix in debug and release on macOS arm64/ROS 2 Jazzy. Modified-file formatting andgit diff --checkpass. No dependency or public API changes.Initial CI passed all five Rust Stable jobs. Rust Minimal/Jazzy failed two unchanged tests that immediately query
/rosoutdiscovery; the new regressions passed. The patch is now reduced to one source file and one focused regression, withoutgeometry_msgsor changelog edits.Downstream context: separate typed-publisher work measured 2.223 → 1.222 ms per 20,000-point publish call (Apple M5 Max, rclrs 0.8/Fast DDS, paired release runs, zero subscribers). That is context for how we encountered this bug, not a performance claim for this fix.
Assisted-by: Codex:gpt-6.1-sol