Repository navigation
Consumer channel replacement fixes - #434
Merged
Merged
Conversation
* Publishing no longer breaks after a replacement: the publisher held on to the old channel and exchange, now it is redeclared with them * Closing a channel the server has already closed is now idempotent * Give running handlers a graceul timeout before the work pool is killed * Acknowledgements go to the channel the deliveryy has arrived on * Handle stale delivery tags better * The cancellation callback captures the channel the consumer subscribed on In addition, this ports a few eventual matchers (such as `await_condition/2`) from RabbitMQ's CT helpers and adopts them to reduce test flakiness. Plus fixes timeouts that are at risk of being too short.
It's arguably uglier than this alternative and is known not to be type checking-friendly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing no longer breaks after a replacement: the publisher held on to the old channel and exchange, now it is redeclared with them
Closing a channel the server has already closed is now idempotent
Give running handlers a graceul timeout before the work pool is killed
Acknowledgements go to the channel the deliveryy has arrived on
Handle stale delivery tags better
The cancellation callback captures the channel the consumer subscribed on
In addition, this ports a few eventual matchers (such as await_condition/2) from RabbitMQ's CT helpers and adopts them to reduce test flakiness.
Plus fixes timeouts that are at risk of being too short.