Repository navigation
Conversation
7 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Range: bytes=0-0 returning the whole entity
getHTTPRange() correctly parses "bytes=0-0" as [0, 0], but CorePlugin::httpGet()
computes the end offset with a truthiness check ($range[1] ?: $nodeSize - 1).
Since (int) 0 is falsy, a request for the first byte is treated as an open-ended
range and the server responds with 206, Content-Range: bytes 0-/
and the full body.
RFC 7233 §2.1 allows first-byte-pos and last-byte-pos to both be 0.
Impact: CDNs and download managers probe object size with "Range: bytes=0-0"
(e.g. Akamai partial object caching) and fail on the mismatched Content-Range,
which breaks delivery of large files behind sabre/dav-based servers such as Nextcloud.
Includes a regression test.