Repository navigation
Improve DAV:multistatus response - #1686
Open
KristofferFM wants to merge 2 commits into
Open
KristofferFM wants to merge 2 commits into
KristofferFM wants to merge 2 commits into
Conversation
related to the specification described in https://www.rfc-editor.org/info/rfc4918/#section-14.24: * Set propstat status 200 instead of 418 in the situation where there is no properties in the response, and at the same time no predefined status for the whole response. * Add support for additional error, responsedescription and location xml elements.
for 200 status instead of 418. Adding tests of new functionality for the response class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In situations with no overall status set and no properties to return in a response xml element, return a propstat with an empty list of properties and 200 OK (instead of 418 as it was before). Although this scenario is not mentioned directly in the specification in https://www.rfc-editor.org/info/rfc4918/#section-14.24, I think this will confuse clients less.
Furhermore, add support for error, responsedescription and location elements as described in above mentioned specification.
Modified one existing testcase to expect 200 instead of 418 and added new tests for the newly supported xml elements.