Repository navigation
add table name validator tests - #111
Merged
Merged
Conversation
Member
Member
|
Hope the exams went well, @DeleMike! |
Member
|
Yeah, it did! What a week!!... |
DeleMike
approved these changes
Oct 17, 2026
andrewtavis
approved these changes
Oct 17, 2026
andrewtavis
left a comment
Member
There was a problem hiding this comment.
praise: From my end as well this is looking great! Thanks, @ashb155! 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
This PR is regarding adding table-driven unit tests for
database.IsValidTableNameanddatabase.IsValidTranslationTableName.Test Scenarios
;,; DROP TABLE,UNION SELECT,--,/*, quotes (' OR '1'='1), spaces, and special characters (-).envsEN), connectors (fromvsFrom), language codes, and suffixes (scribevsScribe).$) regex regressions.###Coverage
database: 14.7% -> 21.5%Related issue