Repository navigation
feat: v2 datasets - #4524
feat: v2 datasets#4524flying-sheep wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
not the best spot for this one-time-run script, but the only script dir we have.
There was a problem hiding this comment.
repeatedly writing into a zip file makes it bigger …
this is smaller since it doesn’t contain duplicate metadata. only other change is that the X_-less keys are now in the file and the old keys are reconstructed in the dataset code.
❌ 12 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
selmanozleyen
left a comment
There was a problem hiding this comment.
Looks good. I think having one file file would be better. I'd also ensure everything with a preset side effect is documented.
I did that!
Agreed, it’s done this way for things this PR touches but I’m sure there are 1–2 spots where it isn’t. |
tests might fail because I overwrote the dataset (forgot to remove
.raw) – should work in 3 hours when the cloudflare cache times out