Repository navigation
fix: handle aggregate group-label collisions - #4527
Closed
pandorTanmay-crypto wants to merge 2 commits into
Closed
pandorTanmay-crypto wants to merge 2 commits into
pandorTanmay-crypto wants to merge 2 commits into
Conversation
Disambiguate underscore-joined labels for distinct multi-column groups. Closes scverse#4526. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use the PR number expected by the release-note CI check. Related to scverse#4527. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
The PR title and release-note filename are now corrected. The remaining validation failure requires either the no milestone label or a milestone; GitHub denies my account permission to apply labels in scverse/scanpy. Could a maintainer add the no milestone label to unblock this check? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4527 +/- ##
=======================================
Coverage 85.11% 85.11%
=======================================
Files 140 140
Lines 12523 12530 +7
=======================================
+ Hits 10659 10665 +6
- Misses 1864 1865 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Closing this PR as it is a violation of our AI policy: https://scverse.org/about/ai_policy/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

sc.get.aggregatejoined multi-column group labels with underscores, causing distinct groups such as("a_b", "c")and("a", "b_c")to collide and raiseValueError. This disambiguates only colliding labels while preserving existing labels otherwise. A release-note fragment is included. Human review remains pending.Validation:
uv run --no-sync pytest -q tests/test_aggregated.py— passed (260 passed, 215 skipped)ruff check --ignore RUF100,PD901 src/scanpy/get/_aggregated.py tests/test_aggregated.py— passedruff format --check src/scanpy/get/_aggregated.py— passeduv build— passed