Repository navigation
test: assert generated SQL parses under the Doris dialect - #47
Merged
Merged
Conversation
Mocked tests validate control flow, not SQL. Every statement emitted by the metadata probe, the read path and the migration is now parsed with sqlglot's Doris dialect (placeholders substituted), so syntax regressions fail offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an offline check that every statement generated by the metadata probe, the read path and the migration parses under sqlglot's Doris dialect (placeholders substituted).
Why: the "No database selected" regression fixed in #46 slipped through because mocked tests never validate SQL. Parsing catches syntax-level mistakes offline; #46 style issues (missing qualifier) are covered by the existing assertions in the same file.
No production code changes.